api: add maxRequestHeaderLimit to ClientTrafficPolicy - #9623
Draft
hsubramanianaks wants to merge 1 commit into
Draft
api: add maxRequestHeaderLimit to ClientTrafficPolicy#9623hsubramanianaks wants to merge 1 commit into
hsubramanianaks wants to merge 1 commit into
Conversation
Adds headers.maxRequestHeaderLimit to ClientTrafficPolicy, mapping to Envoy's HTTP connection manager max_request_headers_kb setting. The value is a resource.Quantity rounded up to the nearest KiB, validated to be at least 1Ki and at most 8192Ki (Envoy's maximum). Requests whose headers exceed the limit receive a 431 response. Scoped to the max-request-header field only (host normalization landed separately in envoyproxy#9115) and named with the *Limit suffix per maintainer feedback on envoyproxy#8825. Fixes envoyproxy#5368 Signed-off-by: Hariharan Subramanian <hsubramanian@microsoft.com>
✅ Deploy Preview for cerulean-figolla-1f9435 ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds headers.maxRequestHeaderLimit to ClientTrafficPolicy, mapping to Envoy's HTTP connection manager max_request_headers_kb setting. The value is a resource.Quantity rounded up to the nearest KiB, validated to be at least 1Ki and at most 8192Ki (Envoy's maximum). Requests whose headers exceed the limit receive a 431 response.
Scoped to the max-request-header field only (host normalization landed separately in #9115) and named with the *Limit suffix per maintainer feedback on #8825.
Fixes #5368
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #
PR Checklist
git commit -s). See DCO: Sign your work./api), the API was discussed and agreed before the implementation. The API change can be in a separate PR, or in the same PR, but the API must be agreed before implementation. N/A if this PR does not contain API changes.make generate gen-check,make lint, and the unit-test/coverage build pass. (Flaky e2e failures are not considered breakages, butgen-check,lint, and coverage MUST pass.)release-notes/current/<section>/<pr-number>-<slug>.md(seerelease-notes/current/README.mdfor sections and naming). N/A if this PR does not contain non-trivial changes.make gen-checkand committed the result if API/helm charts/modules changed.release-notes/current/breaking_changes/.